lkml.org 
[lkml]   [2015]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/2] [media] netup_unidvb: delete null dereference
    Date
    The calls to dev_dbg will not work properly when spi is NULL.  Just use
    pr_debug instead.

    Problem found using scripts/coccinelle/null/deref_null.cocci

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

    ---
    drivers/media/pci/netup_unidvb/netup_unidvb_spi.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_spi.c b/drivers/media/pci/netup_unidvb/netup_unidvb_spi.c
    index f55b327..026895f 100644
    --- a/drivers/media/pci/netup_unidvb/netup_unidvb_spi.c
    +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_spi.c
    @@ -81,8 +81,7 @@ irqreturn_t netup_spi_interrupt(struct netup_spi *spi)
    unsigned long flags;

    if (!spi) {
    - dev_dbg(&spi->master->dev,
    - "%s(): SPI not initialized\n", __func__);
    + pr_debug("%s(): SPI not initialized\n", __func__);
    return IRQ_NONE;
    }
    spin_lock_irqsave(&spi->lock, flags);
    @@ -235,8 +234,7 @@ void netup_spi_release(struct netup_unidvb_dev *ndev)
    struct netup_spi *spi = ndev->spi;

    if (!spi) {
    - dev_dbg(&spi->master->dev,
    - "%s(): SPI not initialized\n", __func__);
    + pr_debug("%s(): SPI not initialized\n", __func__);
    return;
    }
    spin_lock_irqsave(&spi->lock, flags);


    \
     
     \ /
      Last update: 2015-10-17 12:01    [W:6.937 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site