Messages in this thread | | | Date | Fri, 16 Oct 2015 09:48:48 +0100 | From | Marc Zyngier <> | Subject | Re: [PATCH RFC 4/7] genirq/msi: Make the .prepare callback reusable |
| |
On 16/10/15 06:45, Jiang Liu wrote: > On 2015/10/15 23:39, Marc Zyngier wrote: > <snit> >> +int msi_domain_prepare_irqs(struct irq_domain *domain, struct device *dev, >> + int nvec, msi_alloc_info_t *arg) >> +{ >> + struct msi_domain_info *info = domain->host_data; >> + struct msi_domain_ops *ops = info->ops; >> + int ret; >> + >> + ret = ops->msi_check(domain, info, dev); >> + if (ret == 0) >> + ret = ops->msi_prepare(domain, dev, nvec, arg); >> + if (ret) >> + return ret; >> + >> + return 0; > Seems a simple "return ret" is enough:)
Ah! yes! ;-)
M. -- Jazz is not dead. It just smells funny...
| |