lkml.org 
[lkml]   [2015]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 1/2] ACPI / tables: simplify acpi_parse_entries
    From
    Date
    On 10/15/2015 09:44 AM, Sudeep Holla wrote:
    > Hi Rafael,
    >
    > On 01/10/15 16:11, Sudeep Holla wrote:
    >> acpi_parse_entries passes the table end pointer to the sub-table entry
    >> handler. acpi_parse_entries itself could validate the end of an entry
    >> against the table end using the length in the sub-table entry.
    >>
    >> This patch adds the validation of the sub-table entry end using the
    >> length field.This will help to eliminate the need to pass the table end
    >> to the handlers.
    >>
    >> It also moves the check for zero length entry early so that execution of
    >> the handler can be avoided.
    >>
    >> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
    >
    > Now that Al's MADT is queued, can you consider applying these ?
    >

    I think we have to remove my patches from the queue until I can make
    them arch-specific; doing these MADT checks breaks far too many existing
    x86 systems where the firmware does things it should not; re-reading some
    of the ia64 kernel code, there's a pathological case there where it could
    break (but shouldn't if iasl is being used to compile tables). I'll be
    working on the new version today.

    --
    ciao,
    al
    -----------------------------------
    Al Stone
    Software Engineer
    Linaro Enterprise Group
    al.stone@linaro.org
    -----------------------------------


    \
     
     \ /
      Last update: 2015-10-15 18:21    [W:6.380 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site