Messages in this thread | | | Date | Tue, 13 Oct 2015 08:49:27 +0900 | Subject | Re: [PATCH v2] arm: dts: Fix audio card detection on peach boards | From | Krzysztof Kozlowski <> |
| |
2015-10-13 4:10 GMT+09:00 Kukjin Kim <kgene@kernel.org>: > On 10/12/15 22:04, Krzysztof Kozlowski wrote: >> W dniu 12.10.2015 o 21:37, Alim Akhtar pisze: >>> Since commit 2fad972d45c4 ("ARM: dts: Add mclk entry for Peach boards"), >>> sound card detection is broken on peach boards and gives below errors: >>> >>> [ 3.630457] max98090 7-0010: MAX98091 REVID=0x51 >>> [ 3.634233] max98090 7-0010: use default 2.8v micbias >>> [ 3.640985] snow-audio sound: HiFi <-> 3830000.i2s mapping ok >>> [ 3.645307] max98090 7-0010: Invalid master clock frequency >>> [ 3.650824] snow-audio sound: ASoC: Peach-Pi-I2S-MAX98091 late_probe() failed: -22 >>> [ 3.658914] snow-audio sound: snd_soc_register_card failed (-22) >>> [ 3.664366] snow-audio: probe of sound failed with error -22 >>> >>> This patch adds missing assigned-clocks and assigned-clock-parents for >>> pmu_system_controller node which is used as "mclk" for audio codec. >>> >>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >>> Fixes: 2fad972d45c4 ("ARM: dts: Add mclk entry for Peach boards") >>> Cc: <stable@vger.kernel.org> >>> --- >>> Changes since v1: >>> Addressed Krzysztof's review comments. >> >> Looks good, thanks! >> >> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> >> > Applied, thanks.
I see you pulled that one and of_node_put() fix into fixes. Thanks! Can you apply also Sudip's fix for thermal (acked by Lukasz)? I have it my try but since you applied these two already it does not have sense any more.
Best regards, Krzysztof
| |