Messages in this thread | | | Date | Mon, 12 Oct 2015 13:41:42 -0700 | Subject | Re: [PATCH 1/3] doc: dt: fpga: Added Documentation for Xilinx Zynq FPGA manager. | From | Moritz Fischer <> |
| |
Hi Michal, Josh,
On Mon, Oct 12, 2015 at 2:31 AM, Michal Simek <michal.simek@xilinx.com> wrote: > On 10/09/2015 06:04 PM, Josh Cartwright wrote: >> On Fri, Oct 09, 2015 at 12:45:05AM +0200, Moritz Fischer wrote: >>> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> >>> --- >>> .../bindings/fpga/xilinx-zynq-fpga-mgr.txt | 26 ++++++++++++++++++++++ >>> 1 file changed, 26 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/fpga/xilinx-zynq-fpga-mgr.txt >>> >>> diff --git a/Documentation/devicetree/bindings/fpga/xilinx-zynq-fpga-mgr.txt b/Documentation/devicetree/bindings/fpga/xilinx-zynq-fpga-mgr.txt >>> new file mode 100644 >>> index 0000000..82ffda8 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/fpga/xilinx-zynq-fpga-mgr.txt >>> @@ -0,0 +1,26 @@ >>> +Xilinx Zynq FPGA Manager >>> + >>> +Required properties: >>> +- compatible: should contain "xlnx,zynq-devcfg-1.0" >>> +- reg: base address and size for memory mapped io >>> +- interrupt parent: interrupt source phandle >> >> I think you mean 'interrupt-parent', with the hyphen. > > yes. > >> >> Actually, this isn't really a 'required' property of this node, as it >> could be specified in a parent node. > > yes. Normally interrupt-parent is not listed as required property in the > binding doc. Some docs listed it as optional property.
Alright, will correct typo, and mark it as optional unless someone feels strongly against having the optional. > > Thanks, > Michal
Thanks for the feedback,
Moritz
| |