Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] kernel/params.c: remove confusing cast | Date | Fri, 02 Oct 2015 10:47:32 +0930 |
| |
Rasmus Villemoes <linux@rasmusvillemoes.dk> writes: > Both sides of the assignment are const char*, so this cast is > unnecessary and confusing. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Acked-by: Rusty Russell <rusty@rustcorp.com.au>
Thanks, Rusty.
> kernel/params.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/params.c b/kernel/params.c > index b6554aa71094..0b433fdb45eb 100644 > --- a/kernel/params.c > +++ b/kernel/params.c > @@ -709,7 +709,7 @@ static __modinit int add_sysfs_param(struct module_kobject *mk, > mk->mp->attrs[mk->mp->num].mattr.store = param_attr_store; > else > mk->mp->attrs[mk->mp->num].mattr.store = NULL; > - mk->mp->attrs[mk->mp->num].mattr.attr.name = (char *)name; > + mk->mp->attrs[mk->mp->num].mattr.attr.name = name; > mk->mp->attrs[mk->mp->num].mattr.attr.mode = kp->perm; > mk->mp->num++; > > -- > 2.1.3
| |