Messages in this thread | | | Date | Thu, 1 Oct 2015 09:04:19 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH] tracing: use kstrdup_const instead of private implementation |
| |
On Wed, 30 Sep 2015 21:43:00 +0200 Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
> On Wed, Sep 09 2015, Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote: > > ping
Thanks for the reminder. I'll take a look at your patches today.
-- Steve
> > > The kernel now has kstrdup_const/kfree_const for reusing .rodata > > (typically string literals) when possible; there's no reason to > > duplicate that logic in the tracing system. Moreover, as the comment > > above core_kernel_data states, it may not always return true for > > .rodata - that is for example the case on x86_64, where we thus end up > > kstrdup'ing all the passed-in strings. > >
| |