lkml.org 
[lkml]   [2015]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/6] kbuild: Don't pass -rR to selftest makefiles
    Date
    The makefiles under tools/testing/selftests are not real kbuild
    makefiles, they are regular stand alone makefiles. As such they *do*
    want all the standard implicit rules and variables defined.

    So before calling those makefiles, filter -rR out of MAKEFLAGS.

    Without this not all the selftests are built correctly when called via
    the top-level Makefile.

    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
    ---
    Makefile | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/Makefile b/Makefile
    index c186a928d8be..8bbd0bc7329c 100644
    --- a/Makefile
    +++ b/Makefile
    @@ -1079,12 +1079,12 @@ INSTALL_SELFTESTS_PATH = $(abspath $(objtree)/selftests)

    PHONY += kselftest
    kselftest:
    - $(Q)$(MAKE) -C tools/testing/selftests run_tests
    + $(Q)$(MAKE) -C tools/testing/selftests MAKEFLAGS="$(filter-out rR,$(MAKEFLAGS))" run_tests

    # Kernel selftest install
    PHONY += kselftest_install
    kselftest_install:
    - $(Q)$(MAKE) -C tools/testing/selftests INSTALL_PATH=$(INSTALL_SELFTESTS_PATH) install
    + $(Q)$(MAKE) -C tools/testing/selftests MAKEFLAGS="$(filter-out rR,$(MAKEFLAGS))" INSTALL_PATH=$(INSTALL_SELFTESTS_PATH) install

    # ---------------------------------------------------------------------------
    # Modules
    --
    2.1.0


    \
     
     \ /
      Last update: 2015-01-09 10:21    [W:5.358 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site