Messages in this thread | | | Date | Wed, 7 Jan 2015 20:39:08 +0200 | Subject | Re: [PATCH] Fix an infinite retry-loop | From | Andy Shevchenko <> |
| |
On Sun, Jan 4, 2015 at 8:04 PM, Giel van Schijndel <me@mortis.eu> wrote: > This was clearly intended as a retry-10-times loop, but due to the > absence of code incrementing the loop-counter it was practically a > retry-forever loop. > > Rewritten it as a for-loop as well to make the loop-counter increment > (as well as its potential absence) easier to spot.
It's already in upstream in better form.
> --- > drivers/net/ethernet/qlogic/qla3xxx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/qlogic/qla3xxx.c b/drivers/net/ethernet/qlogic/qla3xxx.c > index c2f09af..35a26c9 100644 > --- a/drivers/net/ethernet/qlogic/qla3xxx.c > +++ b/drivers/net/ethernet/qlogic/qla3xxx.c > @@ -144,9 +144,9 @@ static int ql_sem_lock(struct ql3_adapter *qdev, u32 sem_mask, u32 sem_bits) > */ > static int ql_wait_for_drvr_lock(struct ql3_adapter *qdev) > { > - int i = 0; > + int i; > > - while (i < 10) { > + for (i = 0; i < 10; ++i) { > if (i) > ssleep(1); > > -- > 2.1.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
-- With Best Regards, Andy Shevchenko
| |