Messages in this thread | | | Subject | Re: [PATCH net-next v2 0/8] net: extend ethtool link mode bitmaps to 48 bits | From | Ben Hutchings <> | Date | Tue, 06 Jan 2015 23:08:39 +0000 |
| |
On Tue, 2015-01-06 at 17:29 -0500, David Miller wrote: > From: Amir Vadai <amirv@mellanox.com> > Date: Tue, 6 Jan 2015 15:56:33 +0200 > > > Mellanox is about to release next month a driver for a new NIC, with 3 > > new speeds * few link modes for each + new link modes for 10G. > > It seems that we will need to consume almost all the new bits. > > This tells me that the approach to this problem needs to be rethought. > > Maybe we just need to bite the bullet and make a new ETHTOOL_GSET_2 > and ETHTOOL_SSET_2 or whatever you want to name them. > > Then we can define a completely new structure, with 64-bit bitmaps > for link modes or whatever. The ethtool_op callbacks work using > this structure, and only the net/core/ethtool.c code knows about > the older structure and translates to/from for ETHTOOL_{GSET,SSET}.
Agreed.
Ben.
-- Ben Hutchings This sentence contradicts itself - no actually it doesn't. [unhandled content-type:application/pgp-signature] | |