Messages in this thread | | | Date | Tue, 6 Jan 2015 12:26:16 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 2/2] w1: slaves: w1_therm: Add temp attribute |
| |
On Tue, Jan 06, 2015 at 09:19:07PM +0100, Mariusz Gorski wrote: > On Tue, Jan 06, 2015 at 09:42:21AM -0800, Greg Kroah-Hartman wrote: > > On Tue, Jan 06, 2015 at 03:29:56PM +0100, Mariusz Gorski wrote: > > > Add new attribute to simplify reading of current temperature. > > > > > > Signed-off-by: Mariusz Gorski <marius.gorski@gmail.com> > > > --- > > > drivers/w1/slaves/w1_therm.c | 32 ++++++++++++++++++++++++++++++++ > > > 1 file changed, 32 insertions(+) > > > > You add sysfs attributes without adding new Documentation/ABI/ entries, > > which means I can't take this patch series, sorry. Please redo it and > > add the needed information. > > > > Also, temperature should be a standard sensor attribute, so you might > > want to use that subsystem instead of creating your own ABI here. > > Do you mean stuff described in Documentation/thermal/sysfs-api.txt?
Yes, that is the one.
| |