lkml.org 
[lkml]   [2015]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Linux 3.19-rc3
On Tue, Jan 06, 2015 at 12:48:42PM +0100, Peter Zijlstra wrote:
>
>
> Looking at that closure stuff, why is there an smp_mb() in
> closure_wake_up() ? Typically wakeup only needs to imply a wmb.
>
> Also note that __closure_wake_up() starts with a fully serializing
> instruction (xchg) and thereby already implies the full barrier.

Probably no good reason, that code is pretty old :)

If I was to hazard a guess, I had my own lockless linked lists before llist.h
existed and perhaps I did it with atomic_xchg() - which was at least documented
to not imply a barrier. I suppose it should just be dropped.


\
 
 \ /
  Last update: 2015-01-06 13:41    [W:0.091 / U:1.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site