lkml.org 
[lkml]   [2015]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] kbuild: merge bounds.h and asm-offsets.h rules
Hi Michal,



On Fri, 02 Jan 2015 17:04:42 +0100
Michal Marek <mmarek@suse.cz> wrote:

> >
> > -quiet_cmd_bounds = GEN $@
> > -define cmd_bounds
> > +quiet_cmd_offsets = GEN $@
> > +define cmd_offsets
> > (set -e; \
> > - echo "#ifndef __LINUX_BOUNDS_H__"; \
> > - echo "#define __LINUX_BOUNDS_H__"; \
> > + INCLUDE_GUARD=$$(echo __$(notdir $@)__ | tr '[a-z].-' '[A-Z]__'); \
> > + echo "#ifndef $$INCLUDE_GUARD"; \
> > + echo "#define $$INCLUDE_GUARD"; \
>
> I think it would be more readable to write it as
>
> echo "#ifndef $(2)"; \
> ...
>
> and pass the include guard name as an argument to cmd_offsets.
>
> Otherwise it's a great cleanup.
>
> Michal


OK. I have posted v2.


Best Regards
Masahiro Yamada



\
 
 \ /
  Last update: 2015-01-05 08:41    [W:0.042 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site