Messages in this thread | | | Date | Sat, 31 Jan 2015 06:18:30 -0500 | From | Yang Kuankuan <> | Subject | Re: [PATCH v2 03/12] drm: bridge/dw_hdmi: add irq control to suspend/resume |
| |
On 01/31/2015 06:11 AM, Russell King - ARM Linux wrote: > On Fri, Jan 30, 2015 at 06:28:00AM -0500, Yakir Yang wrote: >> diff --git a/drivers/gpu/drm/bridge/dw_hdmi.c b/drivers/gpu/drm/bridge/dw_hdmi.c >> index 2ded957..13f26af 100644 >> --- a/drivers/gpu/drm/bridge/dw_hdmi.c >> +++ b/drivers/gpu/drm/bridge/dw_hdmi.c >> @@ -1745,6 +1745,49 @@ void dw_hdmi_unbind(struct device *dev, struct device *master, void *data) >> } >> EXPORT_SYMBOL_GPL(dw_hdmi_unbind); >> >> +int dw_hdmi_suspend(struct platform_device *pdev, pm_message_t state) >> +{ > ... >> +int dw_hdmi_resume(struct platform_device *pdev) >> +{ > Please arrange for these functions to take a struct device rather than > a struct platform_device. The generic part of this driver should remain > bus-agnostic. > > Thanks. okay, is it good to replace "struct platform_device" with "struct device" ?
Thanks : )
| |