Messages in this thread | | | Date | Thu, 29 Jan 2015 13:14:53 -0800 | From | Jens Axboe <> | Subject | Re: [PATCH] blk-mq: use BUG_ON() |
| |
On 01/29/2015 09:46 AM, Sudip Mukherjee wrote: > use BUG_ON() instead of using if(condition) BUG() > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> > --- > block/blk-mq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/block/blk-mq.c b/block/blk-mq.c > index 8107962..d8f0922 100644 > --- a/block/blk-mq.c > +++ b/block/blk-mq.c > @@ -337,8 +337,7 @@ EXPORT_SYMBOL(__blk_mq_end_request); > > void blk_mq_end_request(struct request *rq, int error) > { > - if (blk_update_request(rq, error, blk_rq_bytes(rq))) > - BUG(); > + BUG_ON(blk_update_request(rq, error, blk_rq_bytes(rq))); > __blk_mq_end_request(rq, error);
This makes it less readable than it was before, so no.
-- Jens Axboe
| |