Messages in this thread | | | Date | Thu, 29 Jan 2015 10:47:19 -0800 | From | David Cohen <> | Subject | Re: [PATCH 8/8] phy: add driver for TI TUSB1210 ULPI PHY |
| |
On Thu, Jan 29, 2015 at 10:25:38AM -0800, David Cohen wrote: > On Thu, Jan 29, 2015 at 10:04:16AM -0800, David Cohen wrote: > > On Thu, Jan 29, 2015 at 10:20:49AM -0600, Felipe Balbi wrote: > > > On Thu, Jan 29, 2015 at 04:30:53PM +0200, Heikki Krogerus wrote: > > > > > Also, I was chatting in private with David and, apparently, there's a > > > > > way to request for eye diagram data from BIOS straight. That's more > > > > > in-line with what we would do for DT-based boots, passing that > > > > > eye-diagram data as a DT attribute. > > > > > > > > > > Care to comment ? If that's the case, I'd rather use that BIOS hook and > > > > > remove ulpi_read() from probe(). > > > > > > > > I'm not familiar with such method. But if there is one, I'm not > > > > against it. I need to check it. > > > > > > David ? Care to comment ? > > > > I agree with Heikki's proposal to use BIOS hook and remove ulpi_read() > > from probe(). That address one of my chicken/egg concerns. > > Oops. I misinterpreted the thread. Heikki didn't propose that :) > Let me get things mature and reply to here.
I talked to David Box (CC'ed him to this reply). We can add an integer value to ACPI and request it during phy's probe using ACPI's Device Specific Data (_DSD). That would end the need to have phy functional during probe (being compatible to BYT-CR and to module support) and would be more compatible to DT as well.
Br, David
> > Br, David > > > > > Br, David > > > > > > > > -- > > > balbi > > > >
| |