Messages in this thread | | | Date | Thu, 29 Jan 2015 15:14:49 +0000 | From | Ian Abbott <> | Subject | Re: [PATCH] staging: comedi: drivers: addi-data: hwdrv_apci3501: Removed variables that is never used |
| |
On 28/01/15 21:51, Rickard Strandqvist wrote: > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > --- > drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c > index 339519a..24126e3 100644 > --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c > +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3501.c > @@ -93,7 +93,6 @@ static int apci3501_write_insn_timer(struct comedi_device *dev, > { > struct apci3501_private *devpriv = dev->private; > unsigned int ul_Command1 = 0; > - int i_Temp; > > if (devpriv->b_TimerSelectMode == ADDIDATA_WATCHDOG) { > > @@ -135,7 +134,7 @@ static int apci3501_write_insn_timer(struct comedi_device *dev, > } > } > > - i_Temp = inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1; > + inl(dev->iobase + APCI3501_TIMER_STATUS_REG) & 0x1;
The ' & 0x1' part produces compiler warnings and should be removed.
I don't know if the inl() call has any side-effects or not, but since it's part of the watchdog functionality of this board, it's safest to leave it in.
> return insn->n; > } > >
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |