Messages in this thread | | | Date | Thu, 29 Jan 2015 14:39:56 +0000 | From | Ian Abbott <> | Subject | Re: [PATCH] staging: comedi: drivers: mite: Removed variables that is never used |
| |
On 28/01/15 22:36, Rickard Strandqvist wrote: > Variable ar assigned a value that is never used. > I have also removed all the code that thereby serves no purpose. > > This was found using a static code analysis program called cppcheck > > Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> > --- > drivers/staging/comedi/drivers/mite.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c > index ffc9e61..8d2903b 100644 > --- a/drivers/staging/comedi/drivers/mite.c > +++ b/drivers/staging/comedi/drivers/mite.c > @@ -494,9 +494,8 @@ EXPORT_SYMBOL_GPL(mite_bytes_read_from_memory_ub); > unsigned mite_dma_tcr(struct mite_channel *mite_chan) > { > struct mite_struct *mite = mite_chan->mite; > - int lkar; > > - lkar = readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel)); > + readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel)); > return readl(mite->mite_io_addr + MITE_TCR(mite_chan->channel)); > } > EXPORT_SYMBOL_GPL(mite_dma_tcr); >
Reading the MITE_LKAR(channel) register won't have any side-effects, so that call to readl() can be removed altogether. In previous versions of the driver, the value of lkar was only used in debugging messages.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |