Messages in this thread | | | Date | Thu, 29 Jan 2015 13:01:53 +0000 | From | Ian Abbott <> | Subject | Re: [PATCH] staging: comedi: drivers: dt2814: Removed variables that is never used |
| |
On 29/01/15 12:52, Ian Abbott wrote: > On 28/01/15 22:33, Rickard Strandqvist wrote: >> Variable ar assigned a value that is never used. >> I have also removed all the code that thereby serves no purpose. >> >> This was found using a static code analysis program called cppcheck >> >> Signed-off-by: Rickard Strandqvist >> <rickard_strandqvist@spectrumdigital.se> >> --- >> drivers/staging/comedi/drivers/dt2814.c | 13 ++++--------- >> 1 file changed, 4 insertions(+), 9 deletions(-) > > Good, apart from the bad English! > > Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
On second thoughts, I retract my 'Reviewed-by'. The patch actually serves to point out a glaring bug in the original code, in that it acquires data in the interrupt routine but just throws it all away!
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |