lkml.org 
[lkml]   [2015]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: comedi: drivers: dt2814: Removed variables that is never used
On 29/01/15 12:52, Ian Abbott wrote:
> On 28/01/15 22:33, Rickard Strandqvist wrote:
>> Variable ar assigned a value that is never used.
>> I have also removed all the code that thereby serves no purpose.
>>
>> This was found using a static code analysis program called cppcheck
>>
>> Signed-off-by: Rickard Strandqvist
>> <rickard_strandqvist@spectrumdigital.se>
>> ---
>> drivers/staging/comedi/drivers/dt2814.c | 13 ++++---------
>> 1 file changed, 4 insertions(+), 9 deletions(-)
>
> Good, apart from the bad English!
>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

On second thoughts, I retract my 'Reviewed-by'. The patch actually
serves to point out a glaring bug in the original code, in that it
acquires data in the interrupt routine but just throws it all away!

--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-


\
 
 \ /
  Last update: 2015-01-29 14:21    [W:0.035 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site