lkml.org 
[lkml]   [2015]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb: renesas: fix extcon dependency
On Wed, Jan 28, 2015 at 10:47:18PM +0100, Arnd Bergmann wrote:
> The renesas usbhs driver calls extcon_get_edev_by_phandle(), which
> is defined in drivers/extcon/extcon-class.c, and that can be a
> loadable module. If the extcon-class support is disabled, usbhs
> will work correctly for all devices that do not need extcon.
>
> However, if extcon-class is a loadable module, and usbhs is
> built-in, the kernel fails to link. In order to solve that,
> we need a Kconfig dependency that allows extcon to be disabled
> but does not allow usbhs built-in if extcon is a module.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/usb/renesas_usbhs/Kconfig b/drivers/usb/renesas_usbhs/Kconfig
> index de83b9d0cd5c..0ea9040b9f10 100644
> --- a/drivers/usb/renesas_usbhs/Kconfig
> +++ b/drivers/usb/renesas_usbhs/Kconfig
> @@ -6,6 +6,7 @@ config USB_RENESAS_USBHS
> tristate 'Renesas USBHS controller'
> depends on USB_GADGET
> depends on ARCH_SHMOBILE || SUPERH || COMPILE_TEST
> + depends on EXTCON || !EXTCON # for module build if extcon is

The comment doesn't make much sense on its own (and when I read it before
reading the above description, it was down right confusing.) Maybe a
longer comment would be a good idea?

--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.


\
 
 \ /
  Last update: 2015-01-29 13:01    [W:0.947 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site