lkml.org 
[lkml]   [2015]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 042/176] ceph: do_sync is never initialized
    Date
    From: Dan Carpenter <dan.carpenter@oracle.com>

    3.12-stable review patch. If anyone has any objections, please let me know.

    ===============

    commit 021b77bee210843bed1ea91b5cad58235ff9c8e5 upstream.

    Probably this code was syncing a lot more often then intended because
    the do_sync variable wasn't set to zero.

    Fixes: c62988ec0910 ('ceph: avoid meaningless calling ceph_caps_revoking if sync_mode == WB_SYNC_ALL.')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Ilya Dryomov <idryomov@redhat.com>
    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    ---
    fs/ceph/addr.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
    index ec3ba43b9faa..f757dffb715e 100644
    --- a/fs/ceph/addr.c
    +++ b/fs/ceph/addr.c
    @@ -672,7 +672,7 @@ static int ceph_writepages_start(struct address_space *mapping,
    int rc = 0;
    unsigned wsize = 1 << inode->i_blkbits;
    struct ceph_osd_request *req = NULL;
    - int do_sync;
    + int do_sync = 0;
    u64 truncate_size, snap_size;
    u32 truncate_seq;

    --
    2.2.2


    \
     
     \ /
      Last update: 2015-01-29 10:21    [W:2.259 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site