Messages in this thread | | | Date | Wed, 28 Jan 2015 12:06:34 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH] x86, microcode: Return error from driver init code when loader is disabled |
| |
On Tue, Jan 27, 2015 at 09:21:09PM -0500, Boris Ostrovsky wrote: > Commits 65cef1311d5d ("x86, microcode: Add a disable chicken bit") and > a18a0f6850d4 ("x86, microcode: Don't initialize microcode code on > paravirt") allow microcode driver skip initialization when microcode > loading is not permitted. > > However, they don't prevent the driver from being loaded since the > init code returns 0. If at some point later the driver gets unloaded > this will result in an oops while trying to deregister the (never > registered) device. > > To avoid this, make init code return an error on paravirt or when > microcode loading is disabled. The driver will then never be loaded. > > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Reported-by: James Digwall <james@dingwall.me.uk> > Cc: stable@vger.kernel.org # 3.18
Applied, thanks.
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
| |