Messages in this thread | | | Date | Wed, 28 Jan 2015 15:06:59 -0600 | From | Xander Huff <> | Subject | Re: [PATCH -rt] lockdep: selftest: fix warnings due to missing PREEMPT_RT conditionals |
| |
On 1/28/2015 1:08 PM, Xander Huff wrote: > From: Josh Cartwright <josh.cartwright@ni.com> > > "lockdep: Selftest: Only do hardirq context test for raw spinlock" > disabled the execution of certain tests with PREEMPT_RT_FULL, but did > not prevent the tests from still being defined. This leads to warnings > like: > > ./linux/lib/locking-selftest.c:574:1: warning: 'irqsafe1_hard_rlock_12' defined but not used [-Wunused-function] > ./linux/lib/locking-selftest.c:574:1: warning: 'irqsafe1_hard_rlock_21' defined but not used [-Wunused-function] > ./linux/lib/locking-selftest.c:577:1: warning: 'irqsafe1_hard_wlock_12' defined but not used [-Wunused-function] > ./linux/lib/locking-selftest.c:577:1: warning: 'irqsafe1_hard_wlock_21' defined but not used [-Wunused-function] > ./linux/lib/locking-selftest.c:580:1: warning: 'irqsafe1_soft_spin_12' defined but not used [-Wunused-function] > ... > > Fixed by wrapping the test definitions in #ifndef CONFIG_PREEMPT_RT_FULL > conditionals. > > Signed-off-by: Josh Cartwright <josh.cartwright@ni.com> > Signed-off-by: Xander Huff <xander.huff@ni.com> > Acked-by: Gratian Crisan <gratian.crisan@ni.com>
FYI: To be clearer, this should apply to all stable RT releases 3.4 and later.
-- Xander Huff Staff Software Engineer National Instruments
| |