Messages in this thread | | | Date | Tue, 27 Jan 2015 13:18:05 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH] cgroup: Initialize root in cgroup_mount |
| |
On Tue, Jan 27, 2015 at 09:46:36AM -0800, Jason Low wrote: > On Tue, 2015-01-27 at 11:10 -0500, Tejun Heo wrote: > > On Mon, Jan 26, 2015 at 04:21:39PM -0800, Jason Low wrote: > > > Compiling kernel/ causes warnings: > > > > > > ... ‘root’ may be used uninitialized in this function > > > ... ‘root’ was declared here > > > > > > This isn't an issue since there is already logic to not use > > > root if we goto out_unlock without setting root. > > > > > > Explicitly initialize root to NULL to suppress this so that we can > > > focus on catching warnings that can potentially cause bigger issues. > > > > Which complier are you using? > > Hi Tejun, one of the versions I am seeing this on is gcc 4.6.3.
Can you plesae try something newer? gcc for a while had trouble with these spurious warnings. 4.6.2 is 3+ years old now.
Thanks.
-- tejun
| |