lkml.org 
[lkml]   [2015]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/4] fd/direct-io: introduce should_dirty for kernel aio
From
On 1/25/15, Christoph Hellwig <hch@infradead.org> wrote:
> On Tue, Jan 13, 2015 at 11:44:46PM +0800, Ming Lei wrote:
>>
>> - if (dio->is_async && dio->rw == READ)
>> + if (dio->is_async && dio->rw == READ && dio->should_dirty)
>> bio_set_pages_dirty(bio);
>>
>> if (sdio->submit_io)
>> @@ -463,13 +464,14 @@ static int dio_bio_complete(struct dio *dio, struct
>> bio *bio)
>> if (!uptodate)
>> dio->io_error = -EIO;
>>
>> - if (dio->is_async && dio->rw == READ) {
>> + if (dio->is_async && dio->rw == READ && dio->should_dirty) {
>
> I'd rather have a ->should_dirrty flag that means we need to call
> bio_check_pages_dirty, And set that either if we have a kernel
> iovec/bvec or dio->is_async && dio->rw == READ.

It may not work for loop because the page may not become dirty
until the read dio is completed, so it just means the caller totally
handles the page dirty if I/O is from kernel.

>
> But why would we even set this if writing from an iovec?

Or just rename it as ->from_user?

>> bio_check_pages_dirty(bio); /* transfers ownership */
>> } else {
>> bio_for_each_segment_all(bvec, bio, i) {
>> struct page *page = bvec->bv_page;
>>
>> - if (dio->rw == READ && !PageCompound(page))
>> + if (dio->rw == READ && !PageCompound(page) &&
>> + dio->should_dirty)
>> set_page_dirty_lock(page);
>
> And this unk could also use some explanation.

This is same, just don't handle page dirty for kernel dio pages.

Thanks,
Ming Lei


\
 
 \ /
  Last update: 2015-01-27 17:21    [W:0.064 / U:2.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site