Messages in this thread | | | Date | Tue, 27 Jan 2015 00:09:03 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 11/18] spi/xilinx: Remove rx_fn and tx_fn pointer |
| |
On Fri, Jan 23, 2015 at 05:08:43PM +0100, Ricardo Ribalda Delgado wrote:
> + switch (xspi->bits_per_word) { > + case 8: > + *(u8 *)(xspi->rx_ptr) = data; > + break; > + case 16: > + *(u16 *)(xspi->rx_ptr) = data; > + break; > + case 32: > *(u32 *)(xspi->rx_ptr) = data; > - xspi->rx_ptr += 4; > + break; > }
Perhaps I'm missing something here but we only seem to be incrementing rx_ptr for the 32 bit case here...
> + xspi->rx_ptr += xspi->bits_per_word/8;
...which looks to duplicate this which handles all cases. Also there's a coding style thing - spaces around the / please. [unhandled content-type:application/pgp-signature] | |