Messages in this thread | | | Subject | Re: [PATCH char-misc-next v2 01/13] misc: mic: SCIF header file and IOCTL interface | From | Sudeep Dutt <> | Date | Mon, 26 Jan 2015 10:07:24 -0800 |
| |
On Sun, 2015-01-25 at 20:41 +0800, Greg Kroah-Hartman wrote: > On Mon, Jan 12, 2015 at 03:09:55PM -0800, Sudeep Dutt wrote: > > + * Errors: > > + * EBADF, ENOTTY > > + * epd is not a valid endpoint descriptor > > + * ECONNREFUSED > > + * The destination was not listening for connections or refused the > > + * connection request > > + * EINVAL > > + * epd is not a valid endpoint descriptor, or > > + * dst.port is not a valid port ID > > + * EISCONN > > + * The endpoint is already connected > > + * ENOMEM > > + * No buffer space is available > > + * ENODEV > > + * The destination node does not exist, or > > + * The node is lost or existed, but is not currently in the network since it > > + * may have crashed > > + * ENOSPC > > + * No port number available for assignment > > + * EOPNOTSUPP > > + * The endpoint is listening and cannot be connected > > +*/ > > Very odd formatting of these error codes here, and other places in this > .h file, please fix them all up and properly wrap your lines. >
Agreed, I have cleaned it up in v3 which will be posted this week.
Thanks, Sudeep Dutt
| |