Messages in this thread | | | Date | Mon, 26 Jan 2015 15:47:51 +0200 | From | Baruch Siach <> | Subject | Re: [PATCH v5 2/2] clocksource: driver for Conexant Digicolor SoC timer |
| |
Hi Daniel,
On Mon, Jan 26, 2015 at 02:44:15PM +0100, Daniel Lezcano wrote: > >diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile > >index 94d90b24b56b..a993c108be67 100644 > >--- a/drivers/clocksource/Makefile > >+++ b/drivers/clocksource/Makefile > >@@ -10,6 +10,7 @@ obj-$(CONFIG_SH_TIMER_TMU) += sh_tmu.o > > obj-$(CONFIG_EM_TIMER_STI) += em_sti.o > > obj-$(CONFIG_CLKBLD_I8253) += i8253.o > > obj-$(CONFIG_CLKSRC_MMIO) += mmio.o > >+obj-$(CONFIG_ARCH_DIGICOLOR) += timer-digicolor.o > > Ah, one minor change I forgot to mention in the last review (sorry about > that). > > Don't depend on the ARCH, add and select a TIMER_DIGICOLOR (or whatever the > name you prefer) in the mach-digicolor/Kconfig and use it here.
OK. I'll make the change. I'm just curious: what is the advantage of having a separate config symbol for the timer?
baruch
-- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
| |