Messages in this thread | | | Date | Mon, 26 Jan 2015 11:53:56 +0100 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH v6 5/7] can: kvaser_usb: Update interface state before exiting on OOM |
| |
On 01/26/2015 11:52 AM, Andri Yngvason wrote: > Quoting Marc Kleine-Budde (2015-01-26 10:50:12) >> On 01/26/2015 11:28 AM, Andri Yngvason wrote: >>> Quoting Ahmed S. Darwish (2015-01-26 05:27:19) >>>> From: Ahmed S. Darwish <ahmed.darwish@valeo.com> >>>> >>>> Update all of the can interface's state and error counters before >>>> trying any skb allocation that can actually fail with -ENOMEM. >>>> >>>> Suggested-by: Marc Kleine-Budde <mkl@pengutronix.de> >>>> Signed-off-by: Ahmed S. Darwish <ahmed.darwish@valeo.com> >>>> --- >>>> drivers/net/can/usb/kvaser_usb.c | 181 ++++++++++++++++++++++---------------- >>>> 1 files changed, 105 insertions(+), 76 deletions(-) >> [..] >> >>> Looks good to me. >> >> Can I add your Acked-by to 5-7? >> > Yes.
Tnx.
Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[unhandled content-type:application/pgp-signature] | |