lkml.org 
[lkml]   [2015]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] crypto: omap: Free memory in error path
Oups,

should be:
free_pages((unsigned long)buf_out, pages);
free_pages((unsigned long)buf_in, pages);


CJ

Le 26/01/2015 06:40, Christophe Jaillet a écrit :
> If only one of the 2 __get_free_pages fails, then there is a memory leak
>
> Signed-off-by: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
> ---
> drivers/crypto/omap-aes.c | 2 ++
> drivers/crypto/omap-des.c | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
> index f79dd41..c2f9333 100644
> --- a/drivers/crypto/omap-aes.c
> +++ b/drivers/crypto/omap-aes.c
> @@ -577,6 +577,8 @@ static int omap_aes_copy_sgs(struct omap_aes_dev *dd)
> buf_out = (void *)__get_free_pages(GFP_ATOMIC, pages);
>
> if (!buf_in || !buf_out) {
> + free_page((unsigned long)buf_out);
> + free_page((unsigned long)buf_in);
> pr_err("Couldn't allocated pages for unaligned cases.\n");
> return -1;
> }
> diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
> index 0b8dcf5..a2f6ca1 100644
> --- a/drivers/crypto/omap-des.c
> +++ b/drivers/crypto/omap-des.c
> @@ -570,6 +570,8 @@ static int omap_des_copy_sgs(struct omap_des_dev *dd)
> buf_out = (void *)__get_free_pages(GFP_ATOMIC, pages);
>
> if (!buf_in || !buf_out) {
> + free_page((unsigned long)buf_out);
> + free_page((unsigned long)buf_in);
> pr_err("Couldn't allocated pages for unaligned cases.\n");
> return -1;
> }



\
 
 \ /
  Last update: 2015-01-26 07:21    [W:0.054 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site