lkml.org 
[lkml]   [2015]   [Jan]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3.10 25/50] gpiolib: of: Correct error handling in of_get_named_gpiod_flags
On 01/25/2015 02:05 PM, Greg Kroah-Hartman wrote:
> On Sun, Jan 25, 2015 at 01:31:49PM -0800, Guenter Roeck wrote:
>> On Sun, Jan 25, 2015 at 10:07:15AM -0800, Greg Kroah-Hartman wrote:
>>> 3.10-stable review patch. If anyone has any objections, please let me know.
>>>
>>> ------------------
>>>
>>> From: Hans Holmberg <hans.holmberg@intel.com>
>>>
>>> commit 7b8792bbdffdff3abda704f89c6a45ea97afdc62 upstream.
>>>
>>> of_get_named_gpiod_flags fails with -EPROBE_DEFER in cases
>>> where the gpio chip is available and the GPIO translation fails.
>>>
>>> This causes drivers to be re-probed erroneusly, and hides the
>>> real problem(i.e. the GPIO number being out of range).
>>>
>>> Signed-off-by: Hans Holmberg <hans.holmberg@intel.com>
>>> Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
>>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>>
>>
>> This patch is causing several build failures.
>>
>> Error log:
>> drivers/gpio/gpiolib-of.c: In function 'of_gpiochip_find_and_xlate':
>> drivers/gpio/gpiolib-of.c:50:3: error: implicit declaration of function 'ERR_PTR'
>>
>> since "#include <linux/err.h>" is missing in drivers/gpio/gpiolib-of.c
>> in the 3.10 kernel.
>
> Thanks for letting me know, I've pushed out a fix for this in the quilt
> tree of patches.
>

Confirmed; build and qemu tests now pass with no errors.

Guenter




\
 
 \ /
  Last update: 2015-01-26 01:41    [W:0.091 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site