Messages in this thread | | | Date | Fri, 23 Jan 2015 01:30:11 +0100 | From | Samuel Thibault <> | Subject | Re: [PATCHv5 2/2] INPUT: Introduce generic trigger/LED pairs to input LEDs |
| |
Samuel Thibault, le Fri 23 Jan 2015 01:10:38 +0100, a écrit : > Dmitry Torokhov, le Sun 04 Jan 2015 15:28:38 -0800, a écrit : > > > + dev = cdev->dev->platform_data; > > > > Umm, platform data is not the best place for storing this. Why not drvdata? > > Ah, actually led_classdev already makes use of it, see the > device_create_with_groups call in led_classdev_register.
Actually I'd say it makes sense to be using the platform_data field: from the point of view of the led object, the input object is indeed something like a platform.
Samuel
| |