Messages in this thread | | | Date | Thu, 22 Jan 2015 10:25:44 +0800 | From | WANG Chao <> | Subject | Re: [PATCH] x86, e820: clean up around sanitize_e820_map() |
| |
Hi, David
On 01/21/15 at 02:51pm, David Rientjes wrote: > On Wed, 7 Jan 2015, WANG Chao wrote: > > > The argument 3 of sanitize_e820_map() will only update upon a successful > > sanitization. Some of the callers may not be aware of this in the past. > > Now clean up these callers. > > > > Signed-off-by: WANG Chao <chaowang@redhat.com> > > Nice, but it's incomplete: it should also cleanup > default_machine_specific_memory_setup().
default_machine_specific_memory_setup() is special. Because boot_params.e820_entries is 8bit unsigned, and sanitize_e820_map() which takes 32bit unsigned, will step on other member of boot_params next to e820_entries.
Thanks WANG Chao
| |