Messages in this thread | | | From | Andri Yngvason <> | Subject | Re: [PATCH v5 2/5] can: kvaser_usb: Consolidate and unify state change handling | Date | Wed, 21 Jan 2015 11:00:02 +0000 |
| |
Quoting Marc Kleine-Budde (2015-01-21 10:44:54) > On 01/21/2015 11:33 AM, Andri Yngvason wrote: > > Quoting Ahmed S. Darwish (2015-01-20 21:45:37) > >> From: Ahmed S. Darwish <ahmed.darwish@valeo.com> > >> > >> Replace most of the can interface's state and error counters > >> handling with the new can-dev can_change_state() mechanism. > >> > >> Suggested-by: Andri Yngvason <andri.yngvason@marel.com> > >> Signed-off-by: Ahmed S. Darwish <ahmed.darwish@valeo.com> > >> --- > >> drivers/net/can/usb/kvaser_usb.c | 114 +++++++++++++++++++-------------------- > >> 1 file changed, 55 insertions(+), 59 deletions(-) > >> > >> diff --git a/drivers/net/can/usb/kvaser_usb.c b/drivers/net/can/usb/kvaser_usb.c > >> index 971c5f9..0386d3f 100644 > >> --- a/drivers/net/can/usb/kvaser_usb.c > >> +++ b/drivers/net/can/usb/kvaser_usb.c > > > Looks good. > > Is this an Acked-by? >
ACK.
-- Andri
| |