lkml.org 
[lkml]   [2015]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] livepatch: support for repatching a function
On Tue, Jan 20, 2015 at 10:56:33AM +0100, Miroslav Benes wrote:
> On Fri, 9 Jan 2015, Josh Poimboeuf wrote:
> > +struct klp_ops {
> > + struct list_head node;
> > + struct list_head func_stack;
> > + struct ftrace_ops fops;
> > +};
>
> I think it would be useful to add some comments for this structure and its
> members (similar to the last paragraph of the changelog above). Maybe it
> is useless now but the code is going to get complicated and it costs
> nothing...

Ok, thanks.

> Otherwise it looks ok to me (except for thing mentioned by Jiri).
>
> Thank you
>
> --
> Miroslav Benes
> SUSE Labs

--
Josh


\
 
 \ /
  Last update: 2015-01-20 14:01    [W:0.160 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site