Messages in this thread | | | Date | Tue, 20 Jan 2015 06:52:15 -0600 | From | Josh Poimboeuf <> | Subject | Re: [PATCH] livepatch: support for repatching a function |
| |
On Tue, Jan 20, 2015 at 10:56:33AM +0100, Miroslav Benes wrote: > On Fri, 9 Jan 2015, Josh Poimboeuf wrote: > > +struct klp_ops { > > + struct list_head node; > > + struct list_head func_stack; > > + struct ftrace_ops fops; > > +}; > > I think it would be useful to add some comments for this structure and its > members (similar to the last paragraph of the changelog above). Maybe it > is useless now but the code is going to get complicated and it costs > nothing...
Ok, thanks.
> Otherwise it looks ok to me (except for thing mentioned by Jiri). > > Thank you > > -- > Miroslav Benes > SUSE Labs
-- Josh
| |