lkml.org 
[lkml]   [2015]   [Jan]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/14] mfd: intel_soc_pmic: Constify struct regmap_config
On Mon, 05 Jan 2015, Krzysztof Kozlowski wrote:

> The regmap_config struct may be const because it is not modified by the
> driver and regmap_init() accepts pointer to const.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/mfd/intel_soc_pmic_core.h | 2 +-
> drivers/mfd/intel_soc_pmic_crc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/intel_soc_pmic_core.h b/drivers/mfd/intel_soc_pmic_core.h
> index 33aacd9baddc..9498d6719847 100644
> --- a/drivers/mfd/intel_soc_pmic_core.h
> +++ b/drivers/mfd/intel_soc_pmic_core.h
> @@ -23,7 +23,7 @@ struct intel_soc_pmic_config {
> unsigned long irq_flags;
> struct mfd_cell *cell_dev;
> int n_cell_devs;
> - struct regmap_config *regmap_config;
> + const struct regmap_config *regmap_config;
> struct regmap_irq_chip *irq_chip;
> };
>
> diff --git a/drivers/mfd/intel_soc_pmic_crc.c b/drivers/mfd/intel_soc_pmic_crc.c
> index c85e2ecb868a..4cc1b324e971 100644
> --- a/drivers/mfd/intel_soc_pmic_crc.c
> +++ b/drivers/mfd/intel_soc_pmic_crc.c
> @@ -111,7 +111,7 @@ static struct mfd_cell crystal_cove_dev[] = {
> },
> };
>
> -static struct regmap_config crystal_cove_regmap_config = {
> +static const struct regmap_config crystal_cove_regmap_config = {
> .reg_bits = 8,
> .val_bits = 8,
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


\
 
 \ /
  Last update: 2015-01-20 13:01    [W:0.100 / U:1.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site