Messages in this thread | | | Date | Fri, 2 Jan 2015 13:14:47 +0100 | Subject | Re: [PATCH] net: wireless: b43legacy: radio.c: Remove unused function | From | Sedat Dilek <> |
| |
On Fri, Jan 2, 2015 at 1:06 PM, Rafał Miłecki <zajec5@gmail.com> wrote: > On 2 January 2015 at 13:05, Rafał Miłecki <zajec5@gmail.com> wrote: >> On 1 January 2015 at 16:46, Rickard Strandqvist >> <rickard_strandqvist@spectrumdigital.se> wrote: >>> Remove the function b43legacy_radio_set_tx_iq() that is not used anywhere. >>> >>> This was partially found by using a static code analysis program called cppcheck. >> >> It seems to be for A-PHY based hardware (with 0x2060 radio id) which >> is not handled by b43legacy. Should be safe to drop this code (we >> won't likely need it). >> >> Ack > > For future, we prefix patches with just a driver name. So this could > be simply called > b43legacy: radio.c: Remove unused function >
Alternatively...
"b43legacy: Remove unused function in radio.c"
BTW, as Arnd Bergmann pointed out [1] how did you test with cppcheck to get such stuff?
- Sedat -
[1] https://lkml.org/lkml/2015/1/2/51
| |