Messages in this thread | | | Date | Fri, 2 Jan 2015 10:40:09 -0700 | From | Jens Axboe <> | Subject | Re: [PATCH] block: fix checking return value of blk_mq_init_queue |
| |
On 01/02/2015 10:34 AM, Al Viro wrote: > On Fri, Jan 02, 2015 at 08:53:11AM -0700, Jens Axboe wrote: >> On 01/02/2015 07:25 AM, Ming Lei wrote: >>> Check IS_ERR_OR_NULL(return value) instead of just return value. >> >> Thanks Ming, applied. > > Umm... Looking at the callers, I'd suggest making it _never_ return NULL - > it's always treates as ERR_PTR(-ENOMEM) anyway. Then the checks would be > just IS_ERR(...). > > IS_ERR_OR_NULL() is very often a sign of lousy calling conventions and > this case is no exception...
I actually made that change when committing it:
http://git.kernel.dk/?p=linux-block.git;a=commit;h=35b489d32fcc37e8735f41aa794b24cf9d1e74f5
-- Jens Axboe
| |