lkml.org 
[lkml]   [2015]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] Drivers: hv: check vmbus_device_create() return value in vmbus_process_offer()
On Mon, Jan 19, 2015 at 08:58:58PM +0300, Dan Carpenter wrote:
> "error" is a crap label name because it doesn't tell you what the code
> does. A better name is "err_free_chan" or something which talks about
> freeing the channel.

If you choose your label names correctly, then most of the time you can
just read the code from top to bottom and understand it without skipping
back and forth.

regards,
dan carpenter



\
 
 \ /
  Last update: 2015-01-19 19:21    [W:0.079 / U:1.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site