Messages in this thread | | | Date | Mon, 19 Jan 2015 21:03:01 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2 1/3] Drivers: hv: check vmbus_device_create() return value in vmbus_process_offer() |
| |
On Mon, Jan 19, 2015 at 08:58:58PM +0300, Dan Carpenter wrote: > "error" is a crap label name because it doesn't tell you what the code > does. A better name is "err_free_chan" or something which talks about > freeing the channel.
If you choose your label names correctly, then most of the time you can just read the code from top to bottom and understand it without skipping back and forth.
regards, dan carpenter
| |