Messages in this thread | | | Date | Mon, 19 Jan 2015 11:28:44 +0100 | From | Johan Hovold <> | Subject | Re: [PATCH] drivers/usb/serial/mos7840.c: remove unused code |
| |
On Tue, Jan 13, 2015 at 05:41:45PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > There is old, unused code that is #defined out by the > use of NOTMOS7840 - this is not defined anywhere. If > NOTMOS7840 is defined then the code will break on null > pointer dereferences on mos7840_port. So the code is > currently unused, and broken anyway, so why not just > remove it.
Makes sense. But why not remove the likewise broken code conditionally compiled on NOTMCS7840 as well?
Care to resend and include that as well?
Thanks, Johan
| |