Messages in this thread | | | From | 敬锐 <> | Subject | Re: [PATCH 08/10] mfd: rtsx: add support for rts524A | Date | Mon, 19 Jan 2015 02:36:17 +0000 |
| |
On 01/18/2015 08:20 PM, Lee Jones wrote: >> +static int rts524a_optimize_phy(struct rtsx_pcr *pcr) >> >+{ >> >+ int err; >> >+ >> >+ err = rtsx_pci_write_register(pcr, RTS524A_PM_CTRL3, >> >+ D3_DELINK_MODE_EN, 0x00); >> >+ if (err < 0) >> >+ return err; > if (err) > err value will never be positive, but I have to make it consistence with driver in other place, because all the check using if (err < 0) form. And maybe, it make reserved for future the function may return positive value.
| |