lkml.org 
[lkml]   [2015]   [Jan]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/4] perf tools: Fix segfault for symbol annotation on TUI
Em Thu, Jan 15, 2015 at 09:20:21AM +0900, Namhyung Kim escreveu:
> On Wed, Jan 14, 2015 at 06:08:52PM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Wed, Jan 14, 2015 at 07:57:49AM -0700, David Ahern escreveu:
> > > On 1/14/15 4:18 AM, Namhyung Kim wrote:
> > > > static inline struct annotation *symbol__annotation(struct symbol *sym)
> > > > {
> > > >- struct sannotation *a = container_of(sym, struct sannotation, symbol);
> > > >- return &a->annotation;
> > > >+ return (void *)sym - symbol_conf.priv_size;

> > > symbol__priv(sym);

> > Amended, thanks.

> Oh, I missed that. Thanks to both of you!

I thought I had, probably did, but in just one of my devel machines,
ended up going as Namhyung did, no biggie, I'll fix it up later, on the
next perf/core devel cycle.

- Arnaldo


\
 
 \ /
  Last update: 2015-01-17 13:41    [W:0.427 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site