Messages in this thread | | | Subject | Re: [linux-nics] [PATCHv4 net] i40e: Implement ndo_gso_check() | From | Jeff Kirsher <> | Date | Thu, 15 Jan 2015 01:03:16 -0800 |
| |
On Wed, 2015-01-14 at 18:24 -0800, Jesse Gross wrote: > On Fri, Dec 26, 2014 at 3:58 PM, Jesse Gross <jesse@nicira.com> wrote: > > On Fri, Dec 5, 2014 at 2:12 PM, Jeff Kirsher > > <jeffrey.t.kirsher@intel.com> wrote: > >> On Fri, 2014-12-05 at 10:41 -0800, Joe Stringer wrote: > >>> ndo_gso_check() was recently introduced to allow NICs to report the > >>> offloading support that they have on a per-skb basis. Add an > >>> implementation for this driver which checks for IPIP, GRE, UDP > >>> tunnels. > >>> > >>> Signed-off-by: Joe Stringer <joestringer@nicira.com> > >>> --- > >>> v4: Simplify the check to just do tunnel header length. > >>> Fix #define style issue. > >>> v3: Drop IPIP and GRE (no driver support even though hw supports it). > >>> Check for UDP outer protocol for UDP tunnels. > >>> v2: Expand to include IP in IP and IPv4/IPv6 inside GRE/UDP tunnels. > >>> Add MAX_INNER_LENGTH (as 80). > >>> --- > >>> drivers/net/ethernet/intel/i40e/i40e_main.c | 12 ++++++++++++ > >>> 1 file changed, 12 insertions(+) > >> > >> Thanks Joe, I will update the patch in my queue with your latest > >> version. > > > > Jeff, as a heads-up, this patch and the corresponding one for fm10k > > will no longer apply now that the ndo has changed. This was changed by > > 5f35227e ("net: Generalize ndo_gso_check to ndo_features_check"). The > > update needed is trivial and is just due to the change in the function > > signature but I'm not sure where you are in the testing process with > > this. > > Jeff - just wanted to check if you had seen this.
Yeah, I have the updated patch in my queue. I was hoping to get this patch pushed later this week. It did not make the series of i40e patches I am preparing to send out in the next couple of hours, but should be in the next series or the series following the next. Holidays put a damper on things unfortunately. [unhandled content-type:application/pgp-signature] | |