Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH 6/8] adm8211: fix error return code | Date | Thu, 15 Jan 2015 14:45:11 +0200 |
| |
Julia Lawall <Julia.Lawall@lip6.fr> writes:
> Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > identifier ret; expression e1,e2; > @@ > ( > if (\(ret < 0\|ret != 0\)) > { ... return ret; } > | > ret = 0 > ) > ... when != ret = e1 > when != &ret > *if(...) > { > ... when != ret = e2 > when forall > return ret; > } > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Thanks, applied to wireless-drivers-next.git.
-- Kalle Valo
| |