Messages in this thread | | | Date | Thu, 15 Jan 2015 09:23:59 +0900 | From | Namhyung Kim <> | Subject | Re: [PATCH v2 2/4] perf tools: Add link argument to dso__find_symbol_by_name() |
| |
On Wed, Jan 14, 2015 at 09:36:34AM -0700, David Ahern wrote: > On 1/14/15 4:18 AM, Namhyung Kim wrote: > >@@ -414,10 +414,24 @@ static struct symbol *symbols__find_by_name(struct rb_root *symbols, > > else if (cmp > 0) > > n = n->rb_right; > > else > >- return &s->sym; > >+ break; > > } > > > >- return NULL; > >+ if (n == NULL) > >+ return NULL; > >+ > >+ /* return first symbol that has same name (if any) */ > >+ for (n = rb_prev(n); n; n = rb_prev(n)) { > >+ struct symbol_name_rb_node *tmp; > >+ > >+ tmp = rb_entry(n, struct symbol_name_rb_node, rb_node); > >+ if (strcmp(tmp->sym.name, s->sym.name)) > > strcmp() == 0?
No, at this point the 's' points to the first symbol that has same name. And if it finds another symbol (tmp) that has same name, it updates the s to point to the tmp and continues. Otherwise it returns with the existing symbol (s).
Thanks, Namhyung
> > >+ break; > >+ > >+ s = tmp; > >+ } > >+ > >+ return &s->sym; > > } > > > > struct symbol *dso__find_symbol(struct dso *dso, > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
| |