lkml.org 
[lkml]   [2015]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RESEND 1/4] ARM: dts: Add power and lid GPIO keys pinctrl for exynos5250-snow
Hello Kukjin,

On 01/14/2015 04:17 PM, Kukjin Kim wrote:
>>
>> &pinctrl_0 {
>> + power_key_irq: power-key-irq {
>> + samsung,pins = "gpx1-3";
>> + samsung,pin-function = <0xf>;
>
> I think, this setting should be same with exynos5250-spring but different.
>
> from: arch/arm/boot/dts/exynos5250-spring.dts
> 491 power_key_irq: power-key-irq {
> 492 samsung,pins = "gpx1-3";
> 493 samsung,pin-function = <0>;
> 494 samsung,pin-pud = <0>;
> 495 samsung,pin-drv = <0>;
> 496 };
>
> Hmm...0xf should be correct so need to fix the spring DT?
>

Yes, the same problem has exynos5250-snow.dts. This is less relevant now
after commit f6a8249f9e55 ("pinctrl: exynos: Lock GPIOs as interrupts
when used as EINTs") that moved the pinmux reconfiguration to
.irq_{request,release}_resources() preventing the pads to be reconfigured
as regulator input/output.

But still for correctness we should audit spring / snow and change to 0xf.

Best regards,
Javier



\
 
 \ /
  Last update: 2015-01-14 17:01    [W:0.052 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site