Messages in this thread | | | Date | Wed, 14 Jan 2015 13:52:19 +0100 | From | Peter Stuge <> | Subject | Re: [PATCH] Added PIDs for Actisense USB Devices Signed-off-by: Mark Glover <> |
| |
Please update your commit message to leave one blank line between the commit message summary and the rest of the message. (This avoids your signed-off-by ending up in the email subject.)
Mark Glover wrote: > +++ b/drivers/usb/serial/ftdi_sio_ids.h .. > +#define CHETCO_SEAGAUGE_PID 0xA548 /* SeaGauge USB Adapter */ > +#define CHETCO_SEAGAUGE__PID 0xA549 /* SeaSwitch USG Apadter */
Please make the macro name match the product name. Also note typo^ here.
//Peter
| |