Messages in this thread | | | Date | Tue, 13 Jan 2015 22:35:18 -0800 | From | Jeremiah Mahler <> | Subject | Re: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration |
| |
Jia He,
On Tue, Dec 16, 2014 at 10:39:38PM +0800, Jia He wrote: > make sparse happy since these two fuchtion are only used in module.c. > tested by successful compilation. > spelling: s/fuchtion/function/
Not sure if "make sparse happy" is the best way to describe what you are doing. You are fixing sparse warnings.
[...] > -void > -kportal_memhog_free (struct libcfs_device_userstate *ldu) > +static void kportal_memhog_free (struct libcfs_device_userstate *ldu)
You might as well fix the checkpatch warning created by this line too.
[...]
These functions aren't used outside of this file so making them static looks correct.
-- - Jeremiah Mahler
| |