lkml.org 
[lkml]   [2015]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration
Jia He,

On Tue, Dec 16, 2014 at 10:39:38PM +0800, Jia He wrote:
> make sparse happy since these two fuchtion are only used in module.c.
> tested by successful compilation.
>
spelling: s/fuchtion/function/

Not sure if "make sparse happy" is the best way to describe what you are
doing. You are fixing sparse warnings.

[...]
> -void
> -kportal_memhog_free (struct libcfs_device_userstate *ldu)
> +static void kportal_memhog_free (struct libcfs_device_userstate *ldu)

You might as well fix the checkpatch warning created by this line too.

[...]

These functions aren't used outside of this file so making them static
looks correct.

--
- Jeremiah Mahler


\
 
 \ /
  Last update: 2015-01-14 07:41    [W:0.474 / U:0.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site