Messages in this thread | | | Date | Tue, 13 Jan 2015 20:12:04 -0500 | From | Chris Mason <> | Subject | Re: [PATCH] Btrfs: avoid build warning on 32-bit |
| |
On Tue, Jan 13, 2015 at 7:16 PM, David Sterba <dsterba@suse.cz> wrote: > On Tue, Jan 13, 2015 at 03:09:03PM +0100, Arnd Bergmann wrote: >> A recent change introduced a type cast from a private 64-bit >> value to a pointer, which works fine on 64-bit architectures, >> but not on 32-bit ones, where it produces a harmless compiler >> warning: >> >> fs/btrfs/extent_io.c: In function 'btrfs_free_io_failure_record': >> fs/btrfs/extent_io.c:2193:13: warning: cast to pointer from integer >> of different size [-Wint-to-pointer-cast] >> >> This adds an intermediate cast to 'unsigned long', which tells >> the compiler to ignore the type mismatch. >> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> Fixes: f612496bca664 ("Btrfs: cleanup the read failure record after >> write >> or when the inode is freeing") > > Already reported, but not merged
I'll take the original cast one for now and we can do the larger cleanup for the next merge window.
-chris
| |