Messages in this thread | | | Date | Tue, 13 Jan 2015 23:29:32 +0000 (UTC) | From | Paul Walmsley <> | Subject | Re: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc |
| |
Hi Suman,
thanks for pitching in on this!
On Tue, 6 Jan 2015, Suman Anna wrote:
> You have removed the return from the above block on failure. If any DT > entry doesn't have the reg property, this will hang the kernel boot. > Just remove the "reg" entry from any of the existing DT, and you will > run into the issue, this is what 6423d6df1440 ("ARM: OMAP2+: hwmod: > check for module address space during init") fixed.
Seems like that's the problem that we need to track down, then. If a hwmod has no MPU-accessible registers, it should still be possible to init the clocks for the device, etc. ...
> Also, are you sure you want to turn the WARN into a pr_debug, it won't > even show during the kernel boot log if the reg base is missing.
No, I'm not sure :-) I guess it depends how many hwmods we'll have with no MPU-accessible registers. We don't seem to have address ranges for the interconnects defined; we could fix that fairly easily.
- Paul
| |