lkml.org 
[lkml]   [2015]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: OMAP2+: hwmod: Fix _wait_target_ready() for hwmods without sysc
Hi Suman,

thanks for pitching in on this!

On Tue, 6 Jan 2015, Suman Anna wrote:

> You have removed the return from the above block on failure. If any DT
> entry doesn't have the reg property, this will hang the kernel boot.
> Just remove the "reg" entry from any of the existing DT, and you will
> run into the issue, this is what 6423d6df1440 ("ARM: OMAP2+: hwmod:
> check for module address space during init") fixed.

Seems like that's the problem that we need to track down, then. If a
hwmod has no MPU-accessible registers, it should still be possible to
init the clocks for the device, etc. ...

> Also, are you sure you want to turn the WARN into a pr_debug, it won't
> even show during the kernel boot log if the reg base is missing.

No, I'm not sure :-) I guess it depends how many hwmods we'll have with
no MPU-accessible registers. We don't seem to have address ranges for the
interconnects defined; we could fix that fairly easily.


- Paul


\
 
 \ /
  Last update: 2015-01-14 00:41    [W:0.100 / U:1.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site